Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sales] Covering the AssignOrderToCustomerObserver by Unit Test #18490

Merged
merged 1 commit into from
Oct 12, 2018
Merged

[Sales] Covering the AssignOrderToCustomerObserver by Unit Test #18490

merged 1 commit into from
Oct 12, 2018

Conversation

eduard13
Copy link
Contributor

@eduard13 eduard13 commented Oct 9, 2018

Description

This PR adds missing unit tests for AssignOrderToCustomerObserver class:

  • \Magento\Sales\Observer\AssignOrderToCustomerObserver

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@eduard13 eduard13 requested a review from rogyar October 9, 2018 15:30
@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Component: Sales Release Line: 2.3 labels Oct 9, 2018
@eduard13 eduard13 mentioned this pull request Oct 10, 2018
Closed
4 tasks
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Oct 10, 2018
@magento-engcom-team magento-engcom-team merged commit 99b04aa into magento:2.3-develop Oct 12, 2018
magento-engcom-team pushed a commit that referenced this pull request Oct 12, 2018
ENGCOM-3147: [Sales] Covering the AssignOrderToCustomerObserver by Un…
adda938 
…it Test #18490
@magento-engcom-team
Copy link
Contributor

Hi @eduard13. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

@gelanivishal gelanivishal mentioned this pull request Oct 12, 2018
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar Awaiting requested review from rogyar

Assignees

@rogyar rogyar

Labels
Component: Sales Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.1
Development

Successfully merging this pull request may close these issues.
3 participants
@eduard13 @magento-engcom-team @rogyar